chore: improve minimizeDiff#1163
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/sv/c/997cba282b6e86278f002322e279fa99d5916126Open in |
|
…#1164) * re-add diffLines size cap, handle trailing commas before ), trim comments * update migrate snapshots for new minimizeDiff blank-line behavior * update cli create snapshots for new minimizeDiff blank-line behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a heavily AI based re-write of
minimizeDiff. The previous implementation had a couple of major problems when run against the following test projects:For the two svelte projects the produced diff is close to perfect IMHO and only contains very understandable changes. Same applies for typescript files inside immich. For svelte files in immich, we will need to wait for sveltejs/svelte#18474, but this can happen at a later point.
Added a couple of regression tests on the go
Checklist